errors: simplify channel state error codes #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Mike, I was going to suggest that the result of this is we will probably end up with on large FAQ page covering a range of errors to do with different operations and requirements they have. After reading the PR description I can see that this is the intent. So happy to go ahead. I think given most of these errors are validation related we can be quite concise about what the different requests should look like. |
kaschula
approved these changes
Oct 28, 2024
There were many error codes for different variants of invalid state message errors. This will quickly become unwieldy and these errors should instead share a single code. Additional context can be included on the error message for specific errors.
mschristensen
force-pushed
the
feature/DTP-1017-simplify-state-error-codes
branch
from
2fe6d2d to
12f1a04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were many error codes for different variants of invalid state message errors. This will quickly become unwieldy and I think it's better if these errors instead share a single code. Additional context can be included on the error message for specific errors.
Error codes each have their own FAQ page. I think we're better off with a single FAQ page for invalid state messages that describes what a valid message is in different contexts.
This is breaking change, but the channel state work that makes use of these codes has not yet been released so it is safe to make the change now.