Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add chat error code for invalid room name #248

Merged
merged 1 commit into from
May 18, 2024

Conversation

vladvelici
Copy link
Contributor

No description provided.

@AndyTWF AndyTWF merged commit dd30f24 into main May 18, 2024
2 checks passed
@AndyTWF AndyTWF deleted the add-chat-error-invalid-room-name branch May 18, 2024 14:13
"101004": "lock was invalidated by a concurrent lock request which now holds the lock"
"101004": "lock was invalidated by a concurrent lock request which now holds the lock",

"102000": "chat room name is invalid"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "room" appropriate?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the currently accepted term - may (or may not) be subject to change in the near future. We'll open another PR if this changes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants