Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json-schema for epoch events: fix namsepace identified field name #218

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

SimonWoolf
Copy link
Member

No description provided.

@SimonWoolf SimonWoolf requested a review from ruimffl September 26, 2023 11:55
@ruimffl
Copy link

ruimffl commented Sep 26, 2023

Thanks for adding me @SimonWoolf, I'll replicate the change in the analytics view.
Should the new field identified map to the new key identified only, or should it map to authenticated when identified is not present, i.e. before this change is live?

@SimonWoolf
Copy link
Member Author

Should the new field identified map to the new key identified only, or should it map to authenticated when identified is not present, i.e. before this change is live?

it's the same key, just renamed. the corresponding change was deployed in realtime last week. (doesn't hugely matter if the data on this isn't available before last week, relatively unlikely anyone's going to notice/care)

some more context: 'authenticated' was renamed 'identified' back in 2015...

@SimonWoolf SimonWoolf merged commit 91e7ea8 into main Sep 26, 2023
2 checks passed
@SimonWoolf SimonWoolf deleted the namespace-fix-fieldname branch September 26, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants