[ECO-4228] Re-enable skipped presence tests #1886
Conversation
maratal
force-pushed
the
fix/1848-refactoring-presence
branch
from
e365faa to
b301249
Compare
…uick identification upon failure).
maratal
force-pushed
the
fix/1876-re-enable-skipped-presence-tests
branch
from
4a1554d to
818df65
Compare
| @@ -128,7 +128,7 @@ class RealtimeClientPresenceTests: XCTestCase { | |||
| XCTAssertFalse(channel.internal.presence.syncComplete) | |||
| } | |||
|
|
|||
| func skipped__test__010__Presence__ProtocolMessage_bit_flag__when_members_are_present() throws { | |||
| func test__FLAKY__010__Presence__ProtocolMessage_bit_flag__when_members_are_present() throws { | |||
There was a problem hiding this comment.
We should be renaming tests now right? FLAKY keyward can be removed if they are not flaky anymore wdyt
There was a problem hiding this comment.
I wanted to do it later when absolutely sure they are alright.
|
I strongly feel we should unskip/fix most of / all of presence tests. Those are needed to make sure protocol 2.0 / no connection serial works as expected. We did the same for ably-java sometime back ably/ably-java#989 |
This may require a lot of effort for each test. This PR contains only tests that just started working normally again at some point. So I've created an umbrella issue for the rest of the presence tests - #1889 |
Closes #1876
In this PR I first removed "skipped" from all presence tests and ran it locally. Those that didn't fail ended up in a loop a few times. Those that failed twice or more were skipped again. Two tests failed once (051 and 030) and I left them active. I've also left FLAKY label for visibility (temporarily).
Read commit messages for more. In total 12 (out of 33) presence tests were unskipped.