Proper RSH8b and RSH3g2a behavior. #1847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n activate) and initialising `clientId` at the same moment (RSH8b). Device's `id` and `secret` no longer are being generated lazily on the first call (RSH8a). I didn't touch any threading code here on purpose, since this PR is already complex enough.
Many tests relied on device details were there by default, so the only way to supply the details there (without proper state machine activation sequence) is to artificially call the `setupLocalDevice()`.
github-actions
bot
temporarily deployed
to
staging/pull/1847/features
github-actions
bot
temporarily deployed
to
staging/pull/1847/jazzydoc
ttypic
reviewed
Dec 21, 2023
github-actions
bot
temporarily deployed
to
staging/pull/1847/features
github-actions
bot
temporarily deployed
to
staging/pull/1847/jazzydoc
github-actions
bot
temporarily deployed
to
staging/pull/1847/features
github-actions
bot
temporarily deployed
to
staging/pull/1847/features
github-actions
bot
temporarily deployed
to
staging/pull/1847/jazzydoc
maratal
force-pushed
the
fix/1177-RSH8b-RSH3g2a
branch
from
6c6f0fb to
9277ab0
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1847/features
github-actions
bot
temporarily deployed
to
staging/pull/1847/jazzydoc
maratal
force-pushed
the
fix/1177-RSH8b-RSH3g2a
branch
from
9277ab0 to
12521f8
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1847/features
github-actions
bot
temporarily deployed
to
staging/pull/1847/jazzydoc
github-actions
bot
temporarily deployed
to
staging/pull/1847/features
Closed
…e deviceSecret (due to wrong spec PCD2 which draws id as not nullable).
maratal
force-pushed
the
fix/1177-RSH8b-RSH3g2a
branch
from
f934274 to
7159d42
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1847/features
github-actions
bot
temporarily deployed
to
staging/pull/1847/jazzydoc
maratal
force-pushed
the
fix/1177-RSH8b-RSH3g2a
branch
from
7159d42 to
1873d81
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1847/features
github-actions
bot
temporarily deployed
to
staging/pull/1847/jazzydoc
github-actions
bot
temporarily deployed
to
staging/pull/1847/features
github-actions
bot
temporarily deployed
to
staging/pull/1847/jazzydoc
Co-authored-by: Lawrence Forooghian <[email protected]>
lawrence-forooghian
approved these changes
Jan 18, 2024
maratal
added a commit
to ably/specification
that referenced
this pull request
Feb 4, 2024
…y/ably-cocoa#1847, where a new device ID is generated as soon as the previous ones are cleared, so that id is never null.
maratal
added a commit
to ably/specification
that referenced
this pull request
Feb 13, 2024
…y/ably-cocoa#1847, where a new device ID is generated as soon as the previous ones are cleared, so that id is never null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1842, #1253 and commit messages for context.