[SDK-3926] Backport #1823 to fix/socketrocket-fix
#1825
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/1825/jazzydoc
lawrence-forooghian
force-pushed
the
socketrocket-fix-plus-PR-1823
branch
from
b9b43ec to
f6f3875
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1825/jazzydoc
lawrence-forooghian
force-pushed
the
socketrocket-fix-plus-PR-1823
branch
from
f6f3875 to
c943fec
Compare
`macos-10.15`, which worked whenever it was that we branched to `fix/socketrocket-fix`, is no longer available. So, let’s explicitly use macOS 11, which would have been what `macos-latest` pointed to at the time of c2ed307.
github-actions
bot
temporarily deployed
to
staging/pull/1825/jazzydoc
lawrence-forooghian
force-pushed
the
socketrocket-fix-plus-PR-1823
branch
from
c943fec to
82a192c
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1825/jazzydoc
The installation now fails on the macos-11 runner: > Warning: You are using macOS 11. > We (and Apple) do not provide support for this old version. > It is expected behaviour that some formulae will fail to build in this old version. > It is expected behaviour that Homebrew will be buggy and slow. > Do not create any issues about this on Homebrew's GitHub repositories. > Do not create any issues even if you think this message is unrelated. > Any opened issues will be immediately closed without response. > Do not ask for help from Homebrew or its maintainers on social media. > You may ask for help in Homebrew's discussions but are unlikely to receive a response. > Try to figure out the problem yourself and submit a fix as a pull request. > We will review it but may or may not accept it. > > xcbeautify: A full installation of Xcode.app 14.0 is required to compile > this software. Installing just the Command Line Tools is not sufficient. > > Xcode 14.0 cannot be installed on macOS 11. > You must upgrade your version of macOS. > Error: xcbeautify: An unsatisfied requirement failed this build. > Error: Process completed with exit code 1.
This is the earliest version of iOS and tvOS now available in Xcode 13.2.1 (the version of Xcode that would have been the default on the macos-latest runner at the time of c2ed307).
lawrence-forooghian
force-pushed
the
socketrocket-fix-plus-PR-1823
branch
from
82a192c to
3b0b1e9
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1825/jazzydoc
Copied from commit 46ee0b0, with a change to `if let foo {` syntax to get it compiling in older Xcode. Needed for cherry-picking the test changes from that commit.
lawrence-forooghian
force-pushed
the
socketrocket-fix-plus-PR-1823
branch
from
3b0b1e9 to
c895341
Compare
lawrence-forooghian
changed the title
fix/socketrocket-fixfix/socketrocket-fix
github-actions
bot
temporarily deployed
to
staging/pull/1825/jazzydoc
github-actions
bot
temporarily deployed
to
staging/pull/1825/jazzydoc
github-actions
bot
temporarily deployed
to
staging/pull/1825/jazzydoc
github-actions
bot
temporarily deployed
to
staging/pull/1825/jazzydoc
github-actions
bot
temporarily deployed
to
staging/pull/1825/jazzydoc
lawrence-forooghian
force-pushed
the
socketrocket-fix-plus-PR-1823
branch
from
149a3f2 to
8626008
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1825/jazzydoc
lawrence-forooghian
force-pushed
the
socketrocket-fix-plus-PR-1823
branch
from
8626008 to
f86a7e2
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1825/jazzydoc
lawrence-forooghian
force-pushed
the
socketrocket-fix-plus-PR-1823
branch
from
f86a7e2 to
3122fd4
Compare
lawrence-forooghian
changed the title
fix/socketrocket-fixfix/socketrocket-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a customer who is using the branch
fix/socketrocket-fix, which contains the commit c2ed307 that’s not onmain. Although we recognise that we need to transition them off that branch and onto our latest releases, we've decided we'd like to offer them a version of the fix for #1817, from PR #1823, on their branch.This PR gets CI working on that branch again and then cherry-picks the fix from #1823 into the branch.