Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-3869] Uppercase PATCH reinforcing #1808

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Conversation

maratal
Copy link
Collaborator

@maratal maratal commented Sep 25, 2023

Closes #1807

…tional("PATCH")") is not equal to ("Optional("patch"). But on CI in Xcode 14.2 it fails with opposite message Optional("patch")") is not equal to ("Optional("PATCH"). Thus to satisfy both Xcodes I've forced to use uppercase in this assertion.
@maratal maratal merged commit 33e0aa0 into main Sep 25, 2023
6 checks passed
@maratal maratal deleted the fix/1807-patch-vs-PATCH branch September 25, 2023 13:48
lawrence-forooghian pushed a commit that referenced this pull request Oct 31, 2023
`git cherry-pick -m1 33e0aa0`

Merge pull request #1808 from ably/fix/1807-patch-vs-PATCH

[SDK-3869] Uppercase PATCH reinforcing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

In Xcode 15 XCTAssertEqual(request.httpMethod, "patch") fails
2 participants