Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a new test for RTL2f spec #1812

Closed
maratal opened this issue Oct 8, 2023 · 2 comments
Closed

Create a new test for RTL2f spec #1812

maratal opened this issue Oct 8, 2023 · 2 comments
Assignees
@maratal
Labels
testing Includes all kinds of automated tests, the way that we run them and the infrastructure around them.

Comments

@maratal
Copy link
Collaborator

maratal commented Oct 8, 2023 •
edited by sync-by-unito bot
Loading

Current test for RTL2f doesn't test what the spec implies (and was removed):

A test should exist to ensure that resumed is always false when a channel first becomes ATTACHED, it is true when the channel is ATTACHED following a successful connection recovery, and is false when the channel is ATTACHED following a failed connection recovery

┆Issue is synchronized with this Jira Task by Unito
@maratal maratal mentioned this issue Oct 8, 2023
Merged
@sync-by-unito
Copy link

sync-by-unito bot commented Oct 8, 2023

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3896

maratal added a commit that referenced this issue Nov 27, 2023
@maratal
Removed RTL2f claim (#1812).
9ea873b
@lawrence-forooghian lawrence-forooghian added the testing Includes all kinds of automated tests, the way that we run them and the infrastructure around them. label Apr 22, 2024
@maratal maratal self-assigned this May 18, 2024
@maratal maratal mentioned this issue May 19, 2024
Closed
maratal added a commit that referenced this issue May 19, 2024
@maratal
Added second test for RTL2f for connection recovery case (issue #1812).
c8524f0
@maratal maratal mentioned this issue May 19, 2024
Merged
@maratal
Copy link
Collaborator Author

maratal commented May 20, 2024

Solved in #1921

@maratal maratal closed this as completed May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maratal maratal

Labels
testing Includes all kinds of automated tests, the way that we run them and the infrastructure around them.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maratal @lawrence-forooghian