Applied coderabbit suggestion for throwIfFrozen method.

ably · Sep 12, 2024 · e22ff7c · e22ff7c
1 parent bfaaba1
commit e22ff7c
Show file tree

Hide file tree

Showing 6 changed files with 21 additions and 50 deletions.
diff --git a/Source/ARTBaseQuery.m b/Source/ARTBaseQuery.m
@@ -1,4 +1,13 @@
 #import "ARTBaseQuery.h"
 
 @implementation ARTBaseQuery
+
+- (void)throwIfFrozen {
+    if (self.isFrozen) {
+        @throw [NSException exceptionWithName:NSObjectInaccessibleException
+                                       reason:[NSString stringWithFormat:@"%@: You can't change query after you've passed it to the receiver.", self.class]
+                                     userInfo:nil];
+    }
+}
+
 @end
diff --git a/Source/ARTDataQuery.m b/Source/ARTDataQuery.m
@@ -48,11 +48,7 @@ - (NSDate *)start {
 }
 
 - (void)setStart:(NSDate *)value {
-    if (self.isFrozen) {
-        @throw [NSException exceptionWithName:NSObjectInaccessibleException
-                                       reason:[NSString stringWithFormat:@"%@: You can't change query after you've passed it to the receiver.", self.class]
-                                     userInfo:nil];
-    }
+    [self throwIfFrozen];
     _start = value;
 }
 
@@ -61,11 +57,7 @@ - (NSDate *)end {
 }
 
 - (void)setEnd:(NSDate *)value {
-    if (self.isFrozen) {
-        @throw [NSException exceptionWithName:NSObjectInaccessibleException
-                                       reason:[NSString stringWithFormat:@"%@: You can't change query after you've passed it to the receiver.", self.class]
-                                     userInfo:nil];
-    }
+    [self throwIfFrozen];
     _end = value;
 }
 
@@ -74,11 +66,7 @@ - (uint16_t)limit {
 }
 
 - (void)setLimit:(uint16_t)value {
-    if (self.isFrozen) {
-        @throw [NSException exceptionWithName:NSObjectInaccessibleException
-                                       reason:[NSString stringWithFormat:@"%@: You can't change query after you've passed it to the receiver.", self.class]
-                                     userInfo:nil];
-    }
+    [self throwIfFrozen];
     _limit = value;
 }
 
@@ -87,11 +75,7 @@ - (ARTQueryDirection)direction {
 }
 
 - (void)setDirection:(ARTQueryDirection)value {
-    if (self.isFrozen) {
-        @throw [NSException exceptionWithName:NSObjectInaccessibleException
-                                       reason:[NSString stringWithFormat:@"%@: You can't change query after you've passed it to the receiver.", self.class]
-                                     userInfo:nil];
-    }
+    [self throwIfFrozen];
     _direction = value;
 }
 
@@ -122,11 +106,7 @@ - (BOOL)untilAttach {
 }
 
 - (void)setUntilAttach:(BOOL)value {
-    if (self.isFrozen) {
-        @throw [NSException exceptionWithName:NSObjectInaccessibleException
-                                       reason:[NSString stringWithFormat:@"%@: You can't change query after you've passed it to the receiver.", self.class]
-                                     userInfo:nil];
-    }
+    [self throwIfFrozen];
     _untilAttach = value;
 }
 

diff --git a/Source/ARTRealtimePresence.m b/Source/ARTRealtimePresence.m
@@ -36,11 +36,7 @@ - (BOOL)waitForSync {
 }
 
 - (void)setWaitForSync:(BOOL)value {
-    if (self.isFrozen) {
-        @throw [NSException exceptionWithName:NSObjectInaccessibleException
-                                       reason:[NSString stringWithFormat:@"%@: You can't change query after you've passed it to the receiver.", self.class]
-                                     userInfo:nil];
-    }
+    [self throwIfFrozen];
     _waitForSync = value;
 }
 

diff --git a/Source/ARTRestPresence.m b/Source/ARTRestPresence.m
@@ -58,11 +58,7 @@ - (NSUInteger)limit {
 }
 
 - (void)setLimit:(NSUInteger)value {
-    if (self.isFrozen) {
-        @throw [NSException exceptionWithName:NSObjectInaccessibleException
-                                       reason:[NSString stringWithFormat:@"%@: You can't change query after you've passed it to the receiver.", self.class]
-                                     userInfo:nil];
-    }
+    [self throwIfFrozen];
     _limit = value;
 }
 
@@ -71,11 +67,7 @@ - (NSString *)clientId {
 }
 
 - (void)setClientId:(NSString *)value {
-    if (self.isFrozen) {
-        @throw [NSException exceptionWithName:NSObjectInaccessibleException
-                                       reason:[NSString stringWithFormat:@"%@: You can't change query after you've passed it to the receiver.", self.class]
-                                     userInfo:nil];
-    }
+    [self throwIfFrozen];
     _clientId = value;
 }
 
@@ -84,11 +76,7 @@ - (NSString *)connectionId {
 }
 
 - (void)setConnectionId:(NSString *)value {
-    if (self.isFrozen) {
-        @throw [NSException exceptionWithName:NSObjectInaccessibleException
-                                       reason:[NSString stringWithFormat:@"%@: You can't change query after you've passed it to the receiver.", self.class]
-                                     userInfo:nil];
-    }
+    [self throwIfFrozen];
     _connectionId = value;
 }
 

diff --git a/Source/ARTStats.m b/Source/ARTStats.m
@@ -41,11 +41,7 @@ - (ARTStatsGranularity)unit {
 }
 
 - (void)setUnit:(ARTStatsGranularity)value {
-    if (self.isFrozen) {
-        @throw [NSException exceptionWithName:NSObjectInaccessibleException
-                                       reason:[NSString stringWithFormat:@"%@: You can't change query after you've passed it to the receiver.", self.class]
-                                     userInfo:nil];
-    }
+    [self throwIfFrozen];
     _unit = value;
 }
 

diff --git a/Source/include/Ably/ARTBaseQuery.h b/Source/include/Ably/ARTBaseQuery.h
@@ -5,4 +5,6 @@
 
 @property (nonatomic, getter=isFrozen) BOOL frozen;
 
+- (void)throwIfFrozen;
+
 @end
Original file line number	Diff line number	Diff line change
Expand Up		@@ -5,4 +5,6 @@

		@property (nonatomic, getter=isFrozen) BOOL frozen;

		- (void)throwIfFrozen;

		@end