Skip to content

Commit

Permalink
fix tvOS
Browse files Browse the repository at this point in the history
  • Loading branch information
umair-ably committed Aug 5, 2024
1 parent 421758c commit 5ff8c49
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 15 deletions.
4 changes: 2 additions & 2 deletions Ably.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -4163,7 +4163,7 @@
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
SWIFT_VERSION = 5.0;
TARGETED_DEVICE_FAMILY = 3;
TVOS_DEPLOYMENT_TARGET = 10.0;
TVOS_DEPLOYMENT_TARGET = 14.0;
};
name = Debug;
};
Expand Down Expand Up @@ -4200,7 +4200,7 @@
SKIP_INSTALL = YES;
SWIFT_VERSION = 5.0;
TARGETED_DEVICE_FAMILY = 3;
TVOS_DEPLOYMENT_TARGET = 10.0;
TVOS_DEPLOYMENT_TARGET = 14.0;
};
name = Release;
};
Expand Down
7 changes: 0 additions & 7 deletions Source/SocketRocket/Internal/Proxy/ARTSRProxyConnect.m
Original file line number Diff line number Diff line change
Expand Up @@ -239,14 +239,7 @@ - (void)_fetchPAC:(NSURL *)PACurl withProxySettings:(NSDictionary *)proxySetting
__weak typeof(self) wself = self;
NSURLRequest *request = [NSURLRequest requestWithURL:PACurl];
NSURLSessionConfiguration *config = [NSURLSessionConfiguration ephemeralSessionConfiguration];
#if TARGET_OS_MACCATALYST // if (@available(iOS 13.0, macCatalyst 13.0, ... doesn't help
config.TLSMinimumSupportedProtocolVersion = tls_protocol_version_TLSv12;

Check warning on line 242 in Source/SocketRocket/Internal/Proxy/ARTSRProxyConnect.m

View workflow job for this annotation

GitHub Actions / check

'setTLSMinimumSupportedProtocolVersion:' is only available on iOS 13.0 or newer [-Wunguarded-availability-new]
#else
if (@available(iOS 13.0, macOS 10.15, tvOS 13.0, *)) {
config.TLSMinimumSupportedProtocolVersion = tls_protocol_version_TLSv12;
} else {
}
#endif
NSURLSession *session = [NSURLSession sessionWithConfiguration:config delegate:nil delegateQueue:nil];
[[session dataTaskWithRequest:request completionHandler:^(NSData *data, NSURLResponse *response, NSError *error) {
__strong typeof(wself) sself = wself;
Expand Down
6 changes: 0 additions & 6 deletions Source/SocketRocket/Internal/Utilities/ARTSRURLUtilities.m
Original file line number Diff line number Diff line change
Expand Up @@ -80,12 +80,6 @@ extern BOOL ARTSRURLRequiresSSL(NSURL *url)
networkServiceType = NSStreamNetworkServiceTypeVoice;
break;

//#if !TARGET_OS_MACCATALYST
// case NSURLNetworkServiceTypeVoIP:
// networkServiceType = NSStreamNetworkServiceTypeVoIP;
// break;
//#endif

#if _ARTSR_XCODE_VERSION_11_OR_LATER
case NSURLNetworkServiceTypeAVStreaming:
networkServiceType = NSStreamNetworkServiceTypeVideo;
Expand Down

0 comments on commit 5ff8c49

Please sign in to comment.