-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor readme fixes. #191
Minor readme fixes. #191
Conversation
WalkthroughThe changes in this pull request primarily focus on updating the Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Outside diff range and nitpick comments (2)
README.md (2)
Line range hint
408-412
: Update unsubscription method referenceThe subscription example is correct, but the text below still refers to the
finish
method instead ofunsubscribe
.-To stop listening for the typing events, call the `finish` method on the returned subscription instance. +To stop listening for the typing events, call the `unsubscribe` method on the returned subscription instance.
Line range hint
425-429
: Update unsubscription method referenceThe subscription example is correct, but the text still refers to the
finish
method instead ofunsubscribe
.-To stop listening for the typing events, call the `finish` method on the returned subscription instance. +To stop listening for the occupancy events, call the `unsubscribe` method on the returned subscription instance.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
README.md
(8 hunks)
🔇 Additional comments (5)
README.md (5)
109-111
: LGTM! Method signature simplified
The removal of the bufferingPolicy
parameter simplifies the API while maintaining the same functionality.
115-115
: LGTM! Method name improved for clarity
The change from finish()
to unsubscribe()
makes the API more intuitive and consistent with common SDK patterns.
Also applies to: 118-118
Line range hint 294-303
: LGTM! Clear example of message history retrieval
The example clearly demonstrates subscription, pagination, and error handling.
327-327
: LGTM! Helpful clarification about data structure
The added note about nested dictionary support is valuable for developers.
467-470
:
Update unsubscription method reference
The subscription example is correct, but the text below still refers to the finish
method instead of unsubscribe
.
-To stop receiving reactions, call the `finish` method on the returned subscription instance.
+To stop receiving reactions, call the `unsubscribe` method on the returned subscription instance.
Likely invalid or redundant comment.
7792e5a
to
8ae80a8
Compare
I'd avoid mentioning
bufferingPolicy
in the README at all. Users can find later in the docs IMHO.Summary by CodeRabbit