make it so that you can always get default values of manager

this is so that we can create test factories that allow us to test the default behaviour except for specific overrides
ably · Sep 26, 2024 · e47096e · e47096e
1 parent 0f7a58a
commit e47096e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 12 deletions.
diff --git a/Sources/AblyChat/RoomLifecycleManager.swift b/Sources/AblyChat/RoomLifecycleManager.swift
@@ -31,15 +31,15 @@ internal actor RoomLifecycleManager<Channel: RoomLifecycleContributorChannel> {
 
     internal init(contributors: [Contributor], logger: InternalLogger, clock: SimpleClock) {
         self.init(
-            current: .initialized,
+            current: nil,
             contributors: contributors,
             logger: logger,
             clock: clock
         )
     }
 
     #if DEBUG
-        internal init(testsOnly_current current: RoomLifecycle, contributors: [Contributor], logger: InternalLogger, clock: SimpleClock) {
+        internal init(testsOnly_current current: RoomLifecycle? = nil, contributors: [Contributor], logger: InternalLogger, clock: SimpleClock) {
             self.init(
                 current: current,
                 contributors: contributors,
@@ -49,8 +49,8 @@ internal actor RoomLifecycleManager<Channel: RoomLifecycleContributorChannel> {
         }
     #endif
 
-    private init(current: RoomLifecycle, contributors: [Contributor], logger: InternalLogger, clock: SimpleClock) {
-        self.current = current
+    private init(current: RoomLifecycle?, contributors: [Contributor], logger: InternalLogger, clock: SimpleClock) {
+        self.current = current ?? .initialized
         self.contributors = contributors
         self.logger = logger
         self.clock = clock

diff --git a/Tests/AblyChatTests/RoomLifecycleManagerTests.swift b/Tests/AblyChatTests/RoomLifecycleManagerTests.swift
@@ -28,14 +28,7 @@ struct RoomLifecycleManagerTests {
     }
 
     private func createManager(
-        contributors: [RoomLifecycleManager<MockRoomLifecycleContributorChannel>.Contributor] = [],
-        clock: SimpleClock = MockSimpleClock()
-    ) -> RoomLifecycleManager<MockRoomLifecycleContributorChannel> {
-        .init(contributors: contributors, logger: TestLogger(), clock: clock)
-    }
-
-    private func createManager(
-        forTestingWhatHappensWhenCurrentlyIn current: RoomLifecycle,
+        forTestingWhatHappensWhenCurrentlyIn current: RoomLifecycle? = nil,
         contributors: [RoomLifecycleManager<MockRoomLifecycleContributorChannel>.Contributor] = [],
         clock: SimpleClock = MockSimpleClock()
     ) -> RoomLifecycleManager<MockRoomLifecycleContributorChannel> {