-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core/lifecycle: wind down contributors by channel during failure scenarios #409
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Coverage Report
File Coverage
|
1e781b7
to
cf5fed9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following from the context of the ticket, this LGTM
…arios At the moment, we wind down the contributor itself. This can lead to situations where if the contributor is a shared channel, another contributor will detach the channel and thus it will never recover. This change fixes this issue by making the comparison on the channel objects themselves. Closes #407
cf5fed9
to
8be0386
Compare
Context
Closes #407
CHA-722
Description
At the moment, we wind down the contributor itself. This can lead to situations where if the contributor is a shared channel, another contributor will detach the channel and thus it will never recover.
This change fixes this issue by making the comparison on the channel objects themselves.
Checklist
Testing Instructions (Optional)
N/A