Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CON-96] feat: add conversation caching and some tests #22

Merged
merged 11 commits into from
Jan 2, 2024

Conversation

ttypic
Copy link
Collaborator

@ttypic ttypic commented Dec 15, 2023

No description provided.

@ttypic ttypic force-pushed the add-tests-and-caching branch from 8e7f279 to 5cbbd63 Compare December 15, 2023 13:58
@ttypic ttypic requested a review from AndyTWF December 15, 2023 13:58
@ttypic ttypic force-pushed the add-tests-and-caching branch from 5cbbd63 to cdb6645 Compare December 15, 2023 21:28
@ttypic ttypic force-pushed the add-tests-and-caching branch from cdb6645 to 356b8f7 Compare December 15, 2023 22:07
constructor(realtime: Realtime) {
this.realtime = realtime;
this.chatApi = new ChatApi((realtime as any).options.clientId);
}

get(conversationId: string) {
return new Conversation(conversationId, this.realtime, this.chatApi);
get(conversationId: string): Conversation {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also have a release method to remove the conversation

@ttypic ttypic merged commit b58179e into create-conversation Jan 2, 2024
1 of 5 checks passed
@AndyTWF AndyTWF deleted the add-tests-and-caching branch July 10, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants