-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CON-96] feat: add conversation caching and some tests #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttypic
force-pushed
the
add-tests-and-caching
branch
from
December 15, 2023 13:58
8e7f279
to
5cbbd63
Compare
ttypic
force-pushed
the
add-tests-and-caching
branch
from
December 15, 2023 21:28
5cbbd63
to
cdb6645
Compare
ttypic
force-pushed
the
add-tests-and-caching
branch
from
December 15, 2023 22:07
cdb6645
to
356b8f7
Compare
AndyTWF
reviewed
Jan 2, 2024
constructor(realtime: Realtime) { | ||
this.realtime = realtime; | ||
this.chatApi = new ChatApi((realtime as any).options.clientId); | ||
} | ||
|
||
get(conversationId: string) { | ||
return new Conversation(conversationId, this.realtime, this.chatApi); | ||
get(conversationId: string): Conversation { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also have a release
method to remove the conversation
[CON-100] feat: delete message sdk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.