Merge pull request #400 from ably/room-lifecycle-release-on-initialized

core/room: transition immediately to released if room is initialized
ably · Nov 14, 2024 · d222e0b · d222e0b
2 parents 0e1b523 + 851c801
commit d222e0b
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/src/core/room-lifecycle-manager.ts b/src/core/room-lifecycle-manager.ts
@@ -789,8 +789,8 @@ export class RoomLifecycleManager {
         return;
       }
 
-      // If we're already detached, then we can transition to released immediately
-      if (this._lifecycle.status === RoomStatus.Detached) {
+      // If we're already detached, or we never attached in the first place, then we can transition to released immediately
+      if (this._lifecycle.status === RoomStatus.Detached || this._lifecycle.status === RoomStatus.Initialized) {
         this._lifecycle.setStatus({ status: RoomStatus.Released });
         return;
       }

diff --git a/test/core/room-lifecycle-manager.test.ts b/test/core/room-lifecycle-manager.test.ts
@@ -2510,6 +2510,23 @@ describe('room lifecycle manager', () => {
       await waitForRoomLifecycleStatus(status, RoomStatus.Released);
     });
 
+    it<TestContext>('resolves immediately and transitions to released if the room is initialized', async (context) => {
+      const status = new DefaultRoomLifecycle('roomId', makeTestLogger());
+      context.firstContributor.emulateStateChange({
+        current: AblyChannelState.Detached,
+        previous: 'initialized',
+        resumed: false,
+        reason: baseError,
+      });
+      status.setStatus({ status: RoomStatus.Initialized });
+
+      const monitor = new RoomLifecycleManager(status, [context.firstContributor], makeTestLogger(), 5);
+
+      await expect(monitor.release()).resolves.toBeUndefined();
+
+      await waitForRoomLifecycleStatus(status, RoomStatus.Released);
+    });
+
     it<TestContext>('resolves to released if existing attempt completes', (context) =>
       new Promise<void>((resolve, reject) => {
         vi.useFakeTimers();