Skip to content

Rename fields

Rename fields #1838

Triggered via pull request December 3, 2024 13:32
Status Failure
Total duration 2m 27s
Artifacts

dev.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

24 errors and 7 warnings
format-check
Process completed with exit code 1.
test-typescript: test/react/hooks/use-messages.test.tsx#L1
Argument of type '{ type: MessageEvents; message: { timestamp: Date; text: string; serial: string; clientId: string; roomId: string; createdAt: Date; action: ChatMessageActions; ... 10 more ...; metadata: {}; }; }' is not assignable to parameter of type 'MessageEventPayload'.
test-typescript: test/react/hooks/use-messages.test.tsx#L1
Expected 10-11 arguments, but got 9.
test-typescript
Process completed with exit code 2.
lint: src/core/chat-api.ts#L112
Unnecessary conditional, value is always truthy
lint: src/core/message-parser.ts#L1
Run autofix to sort these imports!
lint: src/core/message-parser.ts#L27
The catch parameter `err` should be named `error`
lint: src/core/message-parser.ts#L79
'version' is never reassigned. Use 'const' instead
lint: src/core/message-parser.ts#L81
Use a ! assertion to more succinctly remove null and undefined from the type
lint: src/core/message-parser.ts#L88
'timestamp' is never reassigned. Use 'const' instead
lint: src/core/message-parser.ts#L89
'createdAt' is never reassigned. Use 'const' instead
lint: src/core/messages.ts#L551
Unnecessary conditional, expected left-hand side of `??` operator to be possibly null or undefined
lint: src/core/messages.ts#L552
Unnecessary conditional, expected left-hand side of `??` operator to be possibly null or undefined
lint: test/core/messages.integration.test.ts#L150
Unsafe assignment of an `any` value
test/core/chat.integration.test.ts > Chat > should work using basic auth: test/core/chat.integration.test.ts#L64
AssertionError: expected [] to deeply equal ArrayContaining{…} - Expected + Received - ArrayContaining [ - ObjectContaining { - "clientId": "ably-chat-js-client-zn9cr", - "text": "my message", - }, - ] + Array [] ❯ test/core/chat.integration.test.ts:64:27
test/core/chat.integration.test.ts > Chat > should work using msgpack: test/core/chat.integration.test.ts#L83
AssertionError: expected [] to deeply equal ArrayContaining{…} - Expected + Received - ArrayContaining [ - ObjectContaining { - "clientId": "ably-chat-js-client-jvm5b", - "text": "my message", - }, - ] + Array [] ❯ test/core/chat.integration.test.ts:83:27
test/core/helpers.test.ts > helpers > fromEncodedChatMessage > should return a chat message: src/core/message-parser.ts#L85
Error: received incoming message without version ❯ parseMessageX src/core/message-parser.ts:85:11 ❯ parseMessage src/core/message-parser.ts:26:12 ❯ chatMessageFromAblyMessage src/core/helpers.ts:129:10 ❯ chatMessageFromEncoded src/core/helpers.ts:66:10 ❯ test/core/helpers.test.ts:39:22 ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Serialized Error: { code: 50000, statusCode: 500 }
test/core/message-parser.test.ts > parseMessage > should throw an error > should throw an error if message.serial is undefined: test/core/message-parser.test.ts#L130
Error: Expected matching ErrorInfo Compared values have no visual difference. ❯ test/core/message-parser.test.ts:130:10
test/core/message-parser.test.ts > parseMessage > should throw an error > should throw an error if message.version is undefined for update: test/core/message-parser.test.ts#L130
Error: Expected matching ErrorInfo Compared values have no visual difference. ❯ test/core/message-parser.test.ts:130:10
test/core/message-parser.test.ts > parseMessage > should throw an error > should throw an error if message.version is undefined for deletion: test/core/message-parser.test.ts#L130
Error: Expected matching ErrorInfo Compared values have no visual difference. ❯ test/core/message-parser.test.ts:130:10
test/core/message.test.ts > ChatMessage > message versions > throws an error when trying to compare versions belonging to different origin messages: test/core/message.test.ts#L209
Error: Expected matching ErrorInfo Compared values have no visual difference. ❯ test/core/message.test.ts:209:62
test/core/messages.integration.test.ts > messages integration > should be able to retrieve chat history: test/core/messages.integration.test.ts#L235
AssertionError: expected [] to deeply equal [ ObjectContaining{…}, …(2) ] - Expected + Received - Array [ - ObjectContaining { - "clientId": "ably-chat-js-client-zugxal", - "serial": "01733232820416-000@e7dQMoR5ABjFFp75731976:000", - "text": "Hello there!", - }, - ObjectContaining { - "clientId": "ably-chat-js-client-zugxal", - "serial": "01733232820434-000@e7dQMoR5ABjFFp75731976:000", - "text": "I have the high ground!", - }, - ObjectContaining { - "clientId": "ably-chat-js-client-zugxal", - "serial": "01733232820448-000@e7dQMoR5ABjFFp75731976:000", - "text": "You underestimate my power!", - }, - ] + Array [] ❯ test/core/messages.integration.test.ts:235:27
test/core/messages.integration.test.ts > messages integration > should be able to paginate chat history: test/core/messages.integration.test.ts#L335
AssertionError: expected [] to deeply equal [ ObjectContaining{…}, …(2) ] - Expected + Received - Array [ - ObjectContaining { - "clientId": "ably-chat-js-client-mb14y", - "serial": "01733232820779-000@e7d3KqANwBjFFq40808481:000", - "text": "Hello there!", - }, - ObjectContaining { - "clientId": "ably-chat-js-client-mb14y", - "serial": "01733232820796-000@e7d3KqANwBjFFq40808481:000", - "text": "I have the high ground!", - }, - ObjectContaining { - "clientId": "ably-chat-js-client-mb14y", - "serial": "01733232820813-000@e7d3KqANwBjFFq40808481:000", - "text": "You underestimate my power!", - }, - ] + Array [] ❯ test/core/messages.integration.test.ts:335:28
test/core/messages.integration.test.ts > messages integration > should be able to paginate chat history (msgpack): test/core/messages.integration.test.ts#L440
AssertionError: expected [] to deeply equal [ ObjectContaining{…}, …(2) ] - Expected + Received - Array [ - ObjectContaining { - "clientId": "ably-chat-js-client-h34rlr", - "serial": "01733232821109-000@e7dYOS53gBjFFr03294712:000", - "text": "Hello there!", - }, - ObjectContaining { - "clientId": "ably-chat-js-client-h34rlr", - "serial": "01733232821124-000@e7dYOS53gBjFFr03294712:000", - "text": "I have the high ground!", - }, - ObjectContaining { - "clientId": "ably-chat-js-client-h34rlr", - "serial": "01733232821147-000@e7dYOS53gBjFFr03294712:000", - "text": "You underestimate my power!", - }, - ] + Array [] ❯ test/core/messages.integration.test.ts:440:28
audit
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
format-check
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
test-typescript
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
build
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
lint
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
test
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
demo-app
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636