Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional subscriber tests #932

Merged
merged 6 commits into from
Jan 23, 2023
Merged

Additional subscriber tests #932

merged 6 commits into from
Jan 23, 2023

Conversation

AndyTWF
Copy link
Contributor

@AndyTWF AndyTWF commented Jan 23, 2023

Adds two more tests from the "low priority" requirement of #918.

  • Testing that publisher resolution updates sent during a fault are received by the subscriber when the fault is cleared.
  • Testing that subscriber resolution preference updates sent during a fault are received by the publisher when the fault is cleared.

@AndyTWF
Add test for resolution updates
27fa85e 
Adds a test that checks the subscriber receives resolution updates
after a fault occurrs
@AndyTWF
Add test for subscriber resolution preference updates
57ca67b 
Adds a test that checks that if a subscriber resolution preference
update is queued during a fault, it is subsequently sent to the publishers
upon resolution.
@AndyTWF
Comment out test cases for now
a6f43e3
@github-actions github-actions bot temporarily deployed to staging/pull/932/dokka January 23, 2023 10:01 Inactive
@jaley jaley mentioned this pull request Jan 23, 2023
Merged
@AndyTWF
Add subscriber-specific test skip
9b19ac8 
Subscriber tests may fail for reasons different to publishers, so
add a subscriber-specific skipTest
@github-actions github-actions bot temporarily deployed to staging/pull/932/dokka January 23, 2023 10:49 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/932/dokka January 23, 2023 11:16 Inactive
QuintinWillison
QuintinWillison approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@QuintinWillison QuintinWillison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much easier to understand now, thanks! Just one minor observation.

android-test-common/src/main/java/com/ably/tracking/test/android/common/Faults.kt Outdated Show resolved Hide resolved
@AndyTWF
Copy link
Contributor Author

AndyTWF commented Jan 23, 2023

The only CI issues are the same emulator crashes present on main and the core sub testing branch, so will merge this in and continue the debugging process over there.

@AndyTWF AndyTWF merged commit 68ba90e into 918-susbscriber-connectivity-tests Jan 23, 2023
@AndyTWF AndyTWF deleted the 918-additional-tests branch January 23, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuintinWillison QuintinWillison QuintinWillison approved these changes

@jaley jaley Awaiting requested review from jaley

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndyTWF @QuintinWillison