Subscriber Connectivity Tests #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add helper functions to start and stop the subscriber, parameterize the test cases etc.
And fix the other tests
Move ably publishing connection setup into helper methods
AndyTWF
changed the title
They're currently skipped
AndyTWF
added
testing
These weren't previously uploaded
This is due to an issue with KTOR (see comment in the test setup method). Likely to be causing all the timeout issues we have at this API level.
davyskiba
reviewed
Feb 10, 2023
subscribing-sdk/src/androidTest/java/com/ably/tracking/subscriber/NetworkConnectivityTests.kt
Outdated
Show resolved
Hide resolved
subscribing-sdk/src/androidTest/java/com/ably/tracking/subscriber/NetworkConnectivityTests.kt
Outdated
Show resolved
Hide resolved
To bring into line with #994
This saves us having to do lots of expectations and waits in tests.
davyskiba
approved these changes
Feb 14, 2023
This was referenced Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds test cases for the main requirements of #918 to test subscriber behaviour when there are network connectivity issues.
Note, some tests are skipped due to the
skipTestproperty on the fault - to run all tests you can either set the property tofalsefor whichever test you want to run, or remove theassumeFalsecall in the test classes setup method.Current test failure status is below, many of the tests that hang may be related to ably/ably-java#474, which we can confirm once the fix is merged.
Fault before starting subscriber:
TCP Connection Refused - timeout waiting for Ably to connect, as per publisher
TCP Connection Unresponsive - timeout waiting for Ably to connect, as per publisher
Attach unresponsive - throws Exception re attach timeout
Disconnect with failed resume - exception thrown
Enter failed with non-fatal nack - exception thrown
Disconnect and suspend - timeout waiting for Ably to connect
Enter unresponsive - hang
After starting/before stopping subscriber:
TCP Connection Refused - hang
TCP Connection Unresponsive - hang
Detach unresponsive - throws exception re detach timeout
Disconnect and suspend - hang
Reenter on resume failed - hang
Enter unresponsive - hang
Tests checking we get location and publisher updates after a fault:
TCP Connection Unresponsive - hang
Disconnect and suspend - hang