Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Networking connectivity integration test using local proxy #866

Merged
merged 49 commits into from
Jan 13, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
d4e5af6
Barebones test and proxy interface for issue #865
jaley Dec 28, 2022
9a44fd5
Clone of PublisherIntegrationTest using an injected AblyRealtime for …
jaley Dec 28, 2022
12683e3
Hacky log handlers for testing
jaley Dec 28, 2022
4290df2
NetworkingConenctivityTest running through Paul's proxy
jaley Dec 29, 2022
8fc094f
Integrate latest proxy code
jaley Dec 30, 2022
c84f87b
Happy path test passing through proxy
jaley Dec 30, 2022
e115778
Cleanup and refactor some boilerplate
jaley Dec 30, 2022
f2cde37
Adding setup and teardown to reset proxy and other state between tests
jaley Dec 30, 2022
ea3a4a3
WIP: reconnection test failing as ably-java unable to reconnect to re…
jaley Dec 30, 2022
24036e2
Fix proxy reconnection test
jaley Jan 3, 2023
960a9bc
Factor out some boiler plate and cleanup each TrackableStateReceiver …
jaley Jan 3, 2023
365a9cd
Introduce Fault and Proxy abstractions
jaley Jan 5, 2023
ae74a9e
Drive test assertions from fault implementations, and clean things up…
jaley Jan 5, 2023
41624d2
Add test for fault after Trackable is Online
jaley Jan 5, 2023
d959287
Exercise add() and remove() during connectivity tests
jaley Jan 5, 2023
76869bb
Add TCP connection hang fault
jaley Jan 5, 2023
1dc25a0
Oops, accidental check-in of libs folder
jaley Jan 6, 2023
7acfbea
Resolve merge conflicts
jaley Jan 6, 2023
799e1a7
Bump ably-java dependency to pull in hostname verification fix
jaley Jan 6, 2023
ab102a7
Remove unused test dependencies
jaley Jan 6, 2023
ccbd852
Run ./gradlew ktlintFormat
QuintinWillison Jan 9, 2023
0c003db
Fix lint issues in AblyProxy implementation.
QuintinWillison Jan 9, 2023
6859a54
Fix lint issues.
QuintinWillison Jan 10, 2023
dcedccb
Inject Ably API key from test runner project, where BuildConfig will …
QuintinWillison Jan 10, 2023
704e1dd
Ensure that ABLY_API_KEY and MAPBOX_ACCESS_TOKEN BuildConfig properti…
QuintinWillison Jan 10, 2023
388d6b9
Merge branch 'main' into 865-networking-connectivity-system-tests
QuintinWillison Jan 10, 2023
564ad41
Add some SubProject evaluation lifecycle logging.
QuintinWillison Jan 10, 2023
b13d5e8
Move release build unit test coverage check to the emulation workflow…
QuintinWillison Jan 10, 2023
7ab7d3e
Stop injecting secrets into debug BuildConfig that aren't present for…
QuintinWillison Jan 10, 2023
3e5fe1e
Revert "Move release build unit test coverage check to the emulation …
QuintinWillison Jan 10, 2023
9abb49e
Provide escape path for CI check runs (pure unit tests) so that secre…
QuintinWillison Jan 10, 2023
b2c634c
Remove impotent artifact upload.
QuintinWillison Jan 10, 2023
5450f91
Log key events around secrets configuration for sub projects.
QuintinWillison Jan 10, 2023
e1af08a
Merge branch 'main' into 865-networking-connectivity-system-tests
QuintinWillison Jan 10, 2023
3bded6b
Stop trying to be clever by using initWith to DRY things up.
QuintinWillison Jan 10, 2023
d2e73a3
Use empty-string secrets when secrets are not injected by the workflow.
QuintinWillison Jan 10, 2023
bab0c83
Improve the information provided in lifecycle logs for Android runtim…
QuintinWillison Jan 11, 2023
98e35c3
Provide escape slightly hacky (but obvious at least!) escape hatch to…
QuintinWillison Jan 11, 2023
7469b35
Revert unnecessary build configuration changes.
QuintinWillison Jan 11, 2023
24ba199
Revert change to the LocationSourceAbly public API, adding a new Loca…
QuintinWillison Jan 11, 2023
f064353
Fix Ably API key injection.
QuintinWillison Jan 11, 2023
1e96b3a
Merge branch 'main' into 865-networking-connectivity-system-tests
QuintinWillison Jan 11, 2023
02a5d1e
Disable known-to-fail proxy-integration tests at runtime, but keep th…
QuintinWillison Jan 12, 2023
591e51c
Merge branch 'main' into 865-networking-connectivity-system-tests
QuintinWillison Jan 12, 2023
8f1a328
Add contributing guidance around the runtimeSecrets Gradle property.
QuintinWillison Jan 12, 2023
951ec1a
Merge branch 'main' into 865-networking-connectivity-system-tests
QuintinWillison Jan 12, 2023
cf6c2ff
Move notes to notes column.
QuintinWillison Jan 13, 2023
26c04e5
Merge branch 'main' into 865-networking-connectivity-system-tests
QuintinWillison Jan 13, 2023
d093815
Add links to workflows.
QuintinWillison Jan 13, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert unnecessary build configuration changes.
  • Loading branch information
QuintinWillison committed Jan 11, 2023
commit 7469b3502b4b307d99afe3badbd2d5d71cd9ef7e
1 change: 0 additions & 1 deletion android-test-common/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ plugins {
dependencies {
implementation project(':core-sdk')
implementation "io.ably:ably-android:$ably_core_version"
implementation 'com.google.code.gson:gson:2.9.0'
}

android {
Expand Down
1 change: 0 additions & 1 deletion publishing-sdk/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ apply from: '../jacoco.gradle'
android {
defaultConfig {
consumerProguardFiles 'consumer-rules.pro'
testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
}
namespace 'com.ably.tracking.publisher'
}
Expand Down