Replace in-process NetworkConnectivityTests proxy with an external one
#1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings the subscriber implementation in line with the publisher one.
This replaces the in-process proxy with an external proxy that runs on the machine that hosts the Android emulator. We’re doing this so that the proxy code can be reused for the Swift Asset Tracking SDKs. Resolves #1003.
lawrence-forooghian
requested review from
AndyTWF,
jaley,
QuintinWillison and
davyskiba
AndyTWF
approved these changes
Feb 21, 2023
lawrence-forooghian
deleted the
1003-use-sdk-test-proxy-for-NetworkConnectivityTests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the in-process proxy with an external proxy that runs on the machine that hosts the Android emulator. We’re doing this so that the proxy code can be reused for the Swift Asset Tracking SDKs.
The external proxy is https://github.com/ably/sdk-test-proxy – most of its code is the code that’s been removed from AAT Android in this PR.
Resolves #1003.