Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a trackable stalls forever if presence.enter() is interrupted by a disconnection #896

Closed
paddybyers opened this issue Jan 12, 2023 · 4 comments · Fixed by #947
Closed

Adding a trackable stalls forever if presence.enter() is interrupted by a disconnection #896

paddybyers opened this issue Jan 12, 2023 · 4 comments · Fixed by #947
Assignees
@ikbalkaya
Labels
bug Something isn't working. It's clear that this does need to be fixed. important

Comments

@paddybyers
Copy link
Member

This behaviour has been observed during analysis of integration test failures (see #865).

The underlying cause is ably/ably-java#474.

Related: #862
@QuintinWillison QuintinWillison added the bug Something isn't working. It's clear that this does need to be fixed. label Jan 12, 2023
@sync-by-unito
Copy link

sync-by-unito bot commented Jan 12, 2023

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3232

@AndyTWF
Copy link
Contributor

AndyTWF commented Jan 12, 2023

This possibly may be the underlying cause of the timeout issues in the flakey test at #846 ?

@jaley
Copy link
Contributor

jaley commented Jan 25, 2023

@ikbalkaya - I believe your incoming PR to update ably-java will resolve this issue

@ikbalkaya
Copy link
Contributor

@jaley I just had a run with tests against new changes. I'd assume that test for this case would be faultDuringTracking[DisconnectWithFailedResume] If that's the case it fixes the issue, I'll reeanble the test and create a PR on this

@ikbalkaya ikbalkaya mentioned this issue Jan 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ikbalkaya ikbalkaya

Labels
bug Something isn't working. It's clear that this does need to be fixed. important
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reenable disconnect failed resume faults ably/ably-asset-tracking-android
5 participants
@jaley @ikbalkaya @paddybyers @AndyTWF @QuintinWillison