-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/col 3 rewind interval #55
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschristensen
force-pushed
the
feature/COL-3-rewind-interval
branch
2 times, most recently
from
October 17, 2023 15:40
f7b8a56
to
73c671e
Compare
zknill
reviewed
Oct 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good, a few small thoughts/comments here and there
Adds a SequenceResumer middleware that discards messages up until the attach point given by the sequence ID is reached. Can be used in conjunction with a sliding window re-orderer via the OrderedSequenceResumer middleware.
The SyncFunc now returns the sequenceID and stateTimestamp along with the model state snapshot. This is used by the model to rewind to the correct point in the stream.
In order to work around rewind's 100 message limit, we can use a history query with untilAttach to paginate back through messages until the target sequenceID boundary is reached. This has the additional benefit that enabling persisted history on the channel just works, allowing you to extend your state cache TTL.
mschristensen
force-pushed
the
feature/COL-3-rewind-interval
branch
from
October 19, 2023 16:30
7ae2eb9
to
3481701
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.