Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ably connector #1

Merged
merged 112 commits into from
Jul 27, 2022
Merged

Ably connector #1

merged 112 commits into from
Jul 27, 2022

Conversation

owenpearson
Copy link
Collaborator

@owenpearson owenpearson commented May 5, 2022 •
edited by sync-by-unito bot
Loading

@sacOO7 sacOO7 mentioned this pull request May 14, 2022
Closed
sacOO7 added 20 commits May 30, 2022 01:31
@sacOO7
Refactored channels, added proper namespaces to channels
b6f86a8
@sacOO7
Refactored namespace for channel leave
d6b94a0
@sacOO7
refactored ablyconnector, removed unnecessary encrypted channel
b88bb01
@sacOO7
Refactored ably-channel, updated subscribe and error listeners
b1210e9
@sacOO7
Added ably private channel
ef7b636
@sacOO7
Added TODO for AblyPresence Channle whisper
a6cba23
@sacOO7
Fixed methods for creating channels
d2c3884
@sacOO7
Updated presence channel, reformatted code
322f81b
@sacOO7
Reformatted ablyChannel class file
0e91140
@sacOO7
Fixed error listener for AblyChannel
441f7ef
@sacOO7
Fixed ably imports for ably-connector
7a8b28a
@sacOO7
Added basic auth JWT utils
28fb62a
@sacOO7
Added patch for executing channel auth before channel attach
d8da3d2
@sacOO7
Added mock server for generating JWT for given channelName
170b0c9
@sacOO7
Added sequential token request executer
e46b474
@sacOO7
Added auth related methods for authz of private/presence channels
0191ac4
@sacOO7
Added channel auth error handler on failed channel state
c31be4d
@sacOO7
Extracted private method for publishing errors in AblyChannel class
3ad6972
@sacOO7
Fixed auth exports, updated ably-connector to apply authz for channels
afbc3fc
@sacOO7
updated sequential token executer, update auth into a class
9655563
sacOO7 added 28 commits June 23, 2022 01:16
@sacOO7
Added auth-protocol (http/https) support for rest request, added json…
d007b13 
… parsing

for string response
@sacOO7
Added option to set authProtocol externally as a part of options
15fb2c0
@sacOO7
Refactored comments for channel attach
66ffa46
@sacOO7
Added extra attach check before publishing subscribe callback to avoi…
fda93ba 
…d duplicates
@sacOO7
Added exit check to avoid multiple authorization after calling attach…
bc32238 
… randomly
@sacOO7
Added separate typings file to avoid ably imports in js dist
1660c79
@sacOO7
Added separate typings imports in required files
65db5c5
@sacOO7
Increased sleep timeout of a ably channel integration test
e37b666
@sacOO7
updated typings for global lib type declarations
28a6234
@sacOO7
Added test for leaving the public, private and presence channel
4f43bef
@sacOO7
Added token expiry check using ably server time
1b65765
@sacOO7
Added missing declarations for Vue, Axios and jQuery inside global
9e691f0
@sacOO7
Removed unnecessary test-app-setup.json file, updated sandbox
f7ef2d4
@sacOO7
Simplified sandbox implementation, testSetup made easy, refactored tests
e077e70
@sacOO7
Removed unnecessary http request code from utils, updated auth file
25c62e8
@sacOO7
removed sleep statements from channel tests
a5d5b4f
@sacOO7
Added browser check to avoid setting content-type header for XHR request
2a83224
@sacOO7
Declared new type Task synonomous to Function
59a38ab
@sacOO7
Refactored presence-channel with member update
05a7a2d
@sacOO7
Refactored code, removed unnecessary TODO's and added newline at the …
9891d31 
…end of each file
@sacOO7
Refactored code, updated class with function methods
443433b
@sacOO7
Updated tests with class methods
10120c1
@sacOO7
Revert "Updated tests with class methods"
708293e 
This reverts commit 10120c1.
@sacOO7
Fixed subscribe/unsubscribe modified callback issue
a1facdd
@sacOO7
Updated presence callbacks for joining and leaving to return publishe…
32b5b50 
…d data
@sacOO7
Fixed linting errors from the code
d23beca
@sacOO7
Updated auth and token-request to use class methods instead of functions
a6c4c90
@sacOO7
Merge pull request #2 from sac-fork/ably-connector
e2de8ca 
[Feature] ably.js support for laravel-echo
sacOO7
sacOO7 approved these changes Jul 27, 2022
View reviewed changes
Copy link
Collaborator

@sacOO7 sacOO7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sacOO7 sacOO7 merged commit 1d2eb5f into master Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sacOO7 sacOO7 sacOO7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@owenpearson @sacOO7