serialziation issue fixed. fixes #25

abhith · Dec 22, 2018 · add5c88 · add5c88
1 parent 169923a
commit add5c88
Show file tree

Hide file tree

Showing 6 changed files with 23 additions and 65 deletions.
diff --git a/src/Code.Library.Docs/Code.Library.Docs.csproj b/src/Code.Library.Docs/Code.Library.Docs.csproj
@@ -6,6 +6,14 @@
     <UserSecretsId>ebc77ad9-f058-478c-9e78-1b5ba77bd814</UserSecretsId>
   </PropertyGroup>
 
+  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
+    <CodeAnalysisRuleSet />
+  </PropertyGroup>
+
+  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
+    <CodeAnalysisRuleSet />
+  </PropertyGroup>
+
   <ItemGroup>
     <Folder Include="wwwroot\" />
   </ItemGroup>

diff --git a/src/Code.Library.Tests/Code.Library.Tests.csproj b/src/Code.Library.Tests/Code.Library.Tests.csproj
@@ -6,6 +6,14 @@
     <IsPackable>false</IsPackable>
   </PropertyGroup>
 
+  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
+    <CodeAnalysisRuleSet />
+  </PropertyGroup>
+
+  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
+    <CodeAnalysisRuleSet />
+  </PropertyGroup>
+
   <ItemGroup>
     <Compile Remove="Helpers\StringHelperTests.cs" />
     <Compile Remove="Helpers\ValidationHelperTests.cs" />

diff --git a/src/Code.Library/Code.Library.csproj b/src/Code.Library/Code.Library.csproj
@@ -2,21 +2,21 @@
 
   <PropertyGroup>
     <TargetFrameworks>netstandard2.0;net45</TargetFrameworks>
-    <Version>2.0.0-beta.3</Version>
+    <Version>2.0.0-beta.4</Version>
     <Authors>abhith</Authors>
     <Description>Some useful C# helper classes and methods.</Description>
-    <PackageProjectUrl>https://github.com/Abhith/Code.Library</PackageProjectUrl>
+    <PackageProjectUrl>https://code-library.abhith.net</PackageProjectUrl>
     <RepositoryUrl>https://github.com/Abhith/Code.Library</RepositoryUrl>
     <PackageReleaseNotes></PackageReleaseNotes>
     <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Debug|netstandard2.0|AnyCPU'">
-    <CodeAnalysisRuleSet>Code.Library.ruleset</CodeAnalysisRuleSet>
+    <CodeAnalysisRuleSet></CodeAnalysisRuleSet>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Release|netstandard2.0|AnyCPU'">
-    <CodeAnalysisRuleSet>Code.Library.ruleset</CodeAnalysisRuleSet>
+    <CodeAnalysisRuleSet></CodeAnalysisRuleSet>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/src/Code.Library/Helpers/ControlsHelper.cs b/src/Code.Library/Helpers/ControlsHelper.cs
diff --git a/src/Code.Library/Helpers/ExceptionHelper.cs b/src/Code.Library/Helpers/ExceptionHelper.cs
diff --git a/src/Code.Library/Models/Result.cs b/src/Code.Library/Models/Result.cs
@@ -164,7 +164,7 @@ public T Value
             get
             {
                 if (!IsSuccess)
-                    throw new InvalidOperationException("There is no value for failure.");
+                    return default(T);
 
                 return _value;
             }
@@ -238,7 +238,7 @@ public TValue Value
             get
             {
                 if (!IsSuccess)
-                    throw new InvalidOperationException("There is no value for failure.");
+                    return default(TValue);
 
                 return _value;
             }
@@ -334,7 +334,7 @@ public TError Error
             get
             {
                 if (IsSuccess)
-                    throw new InvalidOperationException("There is no error message for success.");
+                    return default(TError);
 
                 return _error;
             }