Fixes a crashing URL test on Linux

Apparently, Foundation's URL#appendingPathComponent crashes cryptically on Linux if you pass it an empty string. Isn't that fun?
aaronsky · May 19, 2020 · 47687d6 · 47687d6
1 parent 44fde33
commit 47687d6
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 221 deletions.
diff --git a/Sources/Buildkite/Networking/APIVersion.swift b/Sources/Buildkite/Networking/APIVersion.swift
@@ -32,8 +32,10 @@ public struct APIVersion {
     }
 
     func url(for path: String) -> URL {
-        baseURL
-            .appendingPathComponent(version)
-            .appendingPathComponent(path)
+        let url = baseURL.appendingPathComponent(version)
+        guard !path.isEmpty else {
+            return url
+        }
+        return url.appendingPathComponent(path)
     }
 }
diff --git a/Tests/BuildkiteTests/XCTestManifests.swift b/Tests/BuildkiteTests/XCTestManifests.swift
diff --git a/Tests/LinuxMain.swift b/Tests/LinuxMain.swift
@@ -1,8 +1,2 @@
-import XCTest
-
-import BuildkiteTests
-
-var tests = [XCTestCaseEntry]()
-tests += BuildkiteTests.__allTests()
-
-XCTMain(tests)
+// LinuxMain.swift
+fatalError("Run the tests with `swift test --enable-test-discovery`.")