Update to latest versions #72
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronpowell
requested changes
Sep 27, 2023
There was a problem hiding this comment.
Thanks for updating the packages, but can you get them updated in paket rather than the fsproj files?
Also, there seems to be some refactoring of the API in there as well, stuff that looks beyond the scope of what'd be needed to update a NuGet package. Can you go over the motivation for that in relation to the overall PR?
samples/FSharp.CosmosDb.Samples.ChangeFeed/FSharp.CosmosDb.Samples.ChangeFeed.fsproj
Outdated
Show resolved
Hide resolved
tests/FSharp.CosmosDb.Analyzer.Tests/FSharp.CosmosDb.Analyzer.Tests.fsproj
Outdated
Show resolved
Hide resolved
…dle versioning instead.
# Conflicts: # src/FSharp.CosmosDb/Types.fs
|
Updated to remove unintended changes. I was using Rider, and it aggressively added the PackageReference elements. I also had a few API changes that should be done on a different pull request. Those have been removed. |
|
This is ready to merge. Your suggested changes have been addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates this project to the latest versions of the CosmosDB and FSharp. I also applied some code style improvement suggestions provided by Rider.