Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to set a device fixture depending on the availability #574

Merged
merged 2 commits into from
May 3, 2024

Conversation

schroedk
Copy link
Collaborator

@schroedk schroedk commented May 3, 2024

Description

This PR closes #573

Changes

  • Add a device fixture, which depending on the availability and user input (--with-cuda) resolves to cuda device.

Checklist

  • Wrote Unit tests (if necessary)
  • Updated Documentation (if necessary)
  • Updated Changelog
  • If notebooks were added/changed, added boilerplate cells are tagged with "tags": ["hide"] or "tags": ["hide-input"]

@schroedk schroedk added this to the v0.9.2 milestone May 3, 2024
@schroedk schroedk marked this pull request as ready for review May 3, 2024 11:35
Copy link
Collaborator

@mdbenito mdbenito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful! But wouldn't one want to run tests both with and without cuda as well?

CONTRIBUTING.md Show resolved Hide resolved
@schroedk
Copy link
Collaborator Author

schroedk commented May 3, 2024

Useful! But wouldn't one want to run tests both with and without cuda as well?

Yes, but I would ask the user to do it manually, and not automatically. In our automatic test environment, we do not have access to cuda anyway.

@schroedk schroedk merged commit c41fa91 into develop May 3, 2024
35 checks passed
@schroedk schroedk deleted the feature/573-manual-cuda-testing branch May 8, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the possibility to manually test on cuda devices
2 participants