Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify progress bars #466

Merged
merged 13 commits into from
Dec 18, 2023
Merged

Conversation

AnesBenmerzoug
Copy link
Collaborator

@AnesBenmerzoug AnesBenmerzoug commented Dec 10, 2023

Description

This PR closes #269

Changes

  • Removed maybe_progress() and used tqdm directly.
  • Created repeat_indices() helper function to avoid repeating futures related pattern for data valuation.

Checklist

  • Wrote Unit tests (if necessary)
  • Updated Documentation (if necessary)
  • Updated Changelog
  • If notebooks were added/changed, added boilerplate cells are tagged with "tags": ["hide"] or "tags": ["hide-input"]

@AnesBenmerzoug AnesBenmerzoug self-assigned this Dec 10, 2023
@mdbenito mdbenito self-requested a review December 13, 2023 13:06
mdbenito
mdbenito previously approved these changes Dec 13, 2023
Copy link
Collaborator

@mdbenito mdbenito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Let's merge after #456 to avoid conflicts there

@AnesBenmerzoug AnesBenmerzoug merged commit 3076b61 into develop Dec 18, 2023
18 checks passed
@mdbenito mdbenito deleted the feature/269-simplify-progress-bars branch February 13, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify progress bars
3 participants