Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/435 broken imports #436

Merged
merged 39 commits into from
Oct 5, 2023
Merged

Fix/435 broken imports #436

merged 39 commits into from
Oct 5, 2023

Conversation

schroedk
Copy link
Collaborator

@schroedk schroedk commented Sep 21, 2023 •
edited
Loading

Description

This PR closes #435, closes #441

Changes

  • Fix issues in notebooks, due to broken imports
  • Fix parsing issues for math formulas
  • Remove background from plots

Checklist

  • [ ] Wrote Unit tests (if necessary)
  • Updated Documentation (if necessary)
  • [ ] Updated Changelog
  • If notebooks were added/changed, added boilerplate cells are tagged with "tags": ["hide"] or "tags": ["hide-input"]

@schroedk
Fix imports in notebooks
524c526
@schroedk
Change artist name for example
25b6474
@schroedk
Changes in executed notebook shapley_basic_spotify
7cbf4e6
@schroedk
Fix import of sklearn datasets
3ae8579
@schroedk
Update output of notebooks/shapley_knn_flowers
26002c3
@schroedk
Fix DataLoader creation, due to dimension miss-match
9f9b289
@schroedk
Fix pre-allocation of tensor bug, due to incorrect data length comput…
7fff43c 
…ation
@schroedk
Update output of notebooks/influence_synthetic
d0c73ab
@schroedk
Update output of notebooks/influence_wine
52f00ff
@schroedk
Fix broken notebook/influence_imagenet:
c02678a 
* update usage of compute_influence
* update usage of plot_influences, plot_losses
* update usage of TrainManager
@schroedk
Fix issue, due to incorrect handling of partial models (only subset o…
7a3b5f0 
…f parameters requires gradients)
@schroedk
Changed output of notebooks/influence_imagenet
f5d617d
@schroedk schroedk marked this pull request as ready for review September 25, 2023 09:26
@schroedk schroedk requested a review from mdbenito September 25, 2023 09:26
mdbenito
mdbenito requested changes Sep 30, 2023
View reviewed changes
Copy link
Collaborator

@mdbenito mdbenito left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schroedk Please note the instructions about notebook cells in the PR description. The new notebooks show the boilerplate and some uninformative output like progress bars.

Additionally, what is the reason to change the artist in the spotify notebook? Rihanna is still among the top values (not asking to change it back, just curious)

Other than that, I think we should merge this quickly.

Also, it would be nice to know what comes out of https://discuss.pytorch.org/t/hessian-vector-products-with-torch-func/184914

schroedk added 11 commits October 1, 2023 17:34
@schroedk schroedk mentioned this pull request Oct 1, 2023
Closed
@schroedk
Copy link
Collaborator Author

schroedk commented Oct 1, 2023

@schroedk Please note the instructions about notebook cells in the PR description. The new notebooks show the boilerplate and some uninformative output like progress bars.

Additionally, what is the reason to change the artist in the spotify notebook? Rihanna is still among the top values (not asking to change it back, just curious)

Other than that, I think we should merge this quickly.

Also, it would be nice to know what comes out of https://discuss.pytorch.org/t/hessian-vector-products-with-torch-func/184914

@mdbenito
I revised the influence_imagenet. Not sure though, which cell to consider as boiler-plate, can you please check back on that?

When running the tests locally, I got a key error for "Rihanna", so I changed the artist.

Unfortunately, I did not get any response on the pytorch discussion forum. I will raise a bug issue on pytorch github.

@schroedk schroedk requested a review from mdbenito October 1, 2023 19:24
schroedk added 15 commits October 4, 2023 15:47
@schroedk
Add a CSS-filter for inverting images in notebook cells, add tags to …
3d42883 
…cells, make background transparent
@schroedk
Hide boilerplate cells in influence notebooks
fd9b5fa
@schroedk
Add warning for omitted code in documentation
6868fc2
@schroedk
Update output and hide cells in notebooks/influence_synthetic
f691a13
@schroedk
Update output of notebooks/influence_wine, add warning for omitted ce…
81643f2 
…lls in documentation
@schroedk
Remove broken link from CONTRIBUTING.md
798d85c
@schroedk
Modify xticks in plots to render nicely
5112a43
@schroedk
Update output of notebooks/data_oob
6f075dd
@schroedk
Capture the output of cells in notebooks/least_core_basic, due to job…
4a655f8 
…lib extensive logging
@schroedk
Update output of notebooks/least_core_basic
ba40203
@schroedk
Merge remote-tracking branch 'origin/develop' into fix/435-broken-imp…
9840d70 
…orts
@schroedk
Remove capture from notebooks/influence_imagenet and use tag to hide …
9429c3e 
…output
@schroedk
Update output of notebooks/influence_imagenet
43c2231
@schroedk
Remove capture from notebooks/least_core_basic and use tag to hide ou…
e29d9f7 
…tput
@schroedk
Update output of notebooks/least_core_basic
71bc46d
mdbenito
mdbenito approved these changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@mdbenito mdbenito left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽 @schroedk Please don't forget to create issues for the final touches (capturing all output, fixing colors in dark mode for notebooks, and anything else I forget)

@mdbenito mdbenito self-assigned this Oct 5, 2023
@mdbenito mdbenito added the documentation Improvements or additions to documentation label Oct 5, 2023
@mdbenito mdbenito merged commit ac3ed99 into develop Oct 5, 2023
12 checks passed
@mdbenito mdbenito deleted the fix/435-broken-imports branch October 5, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdbenito mdbenito mdbenito approved these changes

Assignees

@mdbenito mdbenito

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
2 participants
@schroedk @mdbenito