Remove compression, support file reporting and context passing on the command line #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be used to wire up an output to either the console or any supported file format once the interface is canonicalized.
Factors out driver + compression inference into a separate function.
But for local URIs, we do not require it, which saves one mandatory extra in distribution.
Simplifies everything, since we were not going to use the reporter mixin much, anyway.
nicholasjng
force-pushed
the
improve-cli
branch
from
b22834f to
88c5e8f
Compare
Also give the option to disable typechecks, which is not as useful right now because currently, benchmarks rely on defaults only in command-line mode, so parameters are never passed, and defaults are not typechecked.
nicholasjng
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be used to wire up an output to either the console or any supported file format once the interface is canonicalized.This PR ended up containing a bunch of changes related to file outputs and command line usage of nnbench. Main changes are:
nnbench benchmarks.py -o record.json(or any other supported file format).nnbench benchmarks.py -o s3://my-bucket/record.json(requires fsspec and the file system implementation of choice be installed).nnbench benchmarks.py --context=foo=barcreates a"foo": "bar"key-value pair in the record context. Support for builtin providers (or user-created ones) is still outstanding.