refactor: Remove context class, back to raw dictionaries #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasjng
force-pushed
the
remove-context-class
branch
from
80686ad to
2fbf462
Compare
With flattening and unflattening as functional methods moved into `nnbench.util`. The class was pretty much just a wrapper around a dict with nesting support on a separator, and didn't provide a lot of value on its own. Since we already typed the context provider as a callable returning a raw dictionary, it doesn't create any churn to switch the context out for a raw dict, either.
nicholasjng
force-pushed
the
remove-context-class
branch
from
2fbf462 to
1482b72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With flattening and unflattening as functional methods moved into
nnbench.util.The class was pretty much just a wrapper around a dict with nesting support on a separator, and didn't provide a lot of value on its own.
Since we already typed the context provider as a callable returning a raw dictionary, it doesn't create any churn to switch the context out for a raw dict, either.