Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch if some one has done something silly like passing in a string #601

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Catch if some one has done something silly like passing in a string #601

wants to merge 1 commit into from

Commits on Feb 21, 2019

  1. Catch if some one has done something silly like passing in a string 

    As this is in use on multiple shopify themes, I noticed a few failures where by some one has referenced widths from a data attribute without parsing it. I haven't dived in deep to see the source of the issues, I will, however just thought a sanity check here or further up where the default config is referencing it may be a good idea :)
    @leighs-hammer
    leighs-hammer authored Feb 21, 2019
    Configuration menu
    Copy the full SHA
    d0595d3 View commit details
    Browse the repository at this point in the history