修复战绩详情界面被 ban 英雄飞出组件的内存泄漏问题

Zzaphkiel · Jun 15, 2024 · bea31d8 · bea31d8
1 parent fd640cf
commit bea31d8
Showing 1 changed file with 11 additions and 3 deletions.
diff --git a/app/view/search_interface.py b/app/view/search_interface.py
@@ -423,13 +423,12 @@ def __init__(self, parent=None):
         self.isToolTipInit = False
 
         self.bansFlyOut = None
+        self.bansInfo = None
 
         self.__initWidget()
         self.__initLayout()
 
         cfg.themeChanged.connect(self.__updateIconColor)
-        self.bansButton.clicked.connect(lambda: Flyout.make(
-            self.bansFlyOut, self.bansButton, self, isDeleteOnClose=False))
 
     def __initWidget(self):
         self.teamResultLabel.setObjectName("teamResult")
@@ -455,6 +454,7 @@ def __initWidget(self):
         self.goldIconLabel.setVisible(False)
 
         self.dmgIconLabel.setObjectName("dmgIconLabel")
+        self.bansButton.clicked.connect(self.__onBansButtonClicked)
 
     def __initToolTip(self):
         self.towerIconLabel.setToolTip(self.tr("Tower destroyed"))
@@ -606,9 +606,13 @@ def updateTeam(self, team, isCherry, result):
 
         if len(bans) != 0:
             self.bansButton.setVisible(True)
-            self.bansFlyOut = BansFlyoutView(bans)
+            self.bansInfo = bans
+
+            if self.bansFlyOut:
+                self.bansFlyOut.close()
         else:
             self.bansButton.setVisible(False)
+            self.bansInfo = None
 
         self.csIconLabel.setVisible(True)
         self.goldIconLabel.setVisible(True)
@@ -638,6 +642,10 @@ def __updateIconColor(self, theme: Theme):
         self.csIconLabel.setPixmap(QPixmap(f"app/resource/images/Minions_{color}.png").scaled(
             16, 16, Qt.KeepAspectRatio, Qt.SmoothTransformation))
 
+    def __onBansButtonClicked(self):
+        flyout = BansFlyoutView(self.bansInfo)
+        self.bansFlyOut = Flyout.make(flyout, self.bansButton, self)
+
 
 class BansFlyoutView(FlyoutViewBase):
     def __init__(self, bans, parent=None):