Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log ListenAndServe errors #207

Merged
merged 1 commit into from
Sep 1, 2024

Conversation

matsuu
Copy link
Contributor

@matsuu matsuu commented Sep 1, 2024

logging to detect issues such as "bind: address already in use".

logging to detect issues such as "bind: address already in use".
@matsuu matsuu requested a review from Zxilly as a code owner September 1, 2024 03:23
Copy link

codecov bot commented Sep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #207   +/-   ##
=======================================
  Coverage   92.55%   92.55%           
=======================================
  Files          87       87           
  Lines        4740     4740           
  Branches      251      251           
=======================================
  Hits         4387     4387           
  Misses        279      279           
  Partials       74       74           
Flag Coverage Δ
integration 65.62% <100.00%> (ø)
ui 93.76% <ø> (ø)
unit 41.22% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📢 Thoughts on this report? Let us know!

Copy link
Owner

@Zxilly Zxilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Zxilly Zxilly merged commit 5be8ec4 into Zxilly:master Sep 1, 2024
34 checks passed
@Zxilly
Copy link
Owner

Zxilly commented Sep 1, 2024

Thanks!

@matsuu matsuu deleted the enhance/logging-for-listen-error branch September 2, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants