fix: only slide ptr when necessary

Signed-off-by: Zxilly <[email protected]>
Zxilly · Oct 21, 2024 · ab722e8 · ab722e8
1 parent 8ca73eb
commit ab722e8
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/internal/wrapper/macho.go b/internal/wrapper/macho.go
@@ -17,10 +17,21 @@ import (
 )
 
 type MachoWrapper struct {
-	file *macho.File
+	file           *macho.File
+	chainedFixedUp bool
+}
+
+func NewMachoWrapper(f *macho.File) *MachoWrapper {
+	return &MachoWrapper{
+		file:           f,
+		chainedFixedUp: f.HasDyldChainedFixups(),
+	}
 }
 
 func (m *MachoWrapper) SlidePointer(addr uint64) uint64 {
+	if !m.chainedFixedUp {
+		return addr
+	}
 	return m.file.SlidePointer(addr) + m.file.GetBaseAddress()
 }
 

diff --git a/internal/wrapper/wrapper.go b/internal/wrapper/wrapper.go
@@ -32,7 +32,7 @@ func NewWrapper(file any) RawFileWrapper {
 	case *pe.File:
 		return &PeWrapper{f, utils.GetImageBase(f)}
 	case *macho.File:
-		return &MachoWrapper{f}
+		return NewMachoWrapper(f)
 	}
 	return nil
 }