Skip to content

Commit

Permalink
Add sphinc rtd theme to deps
Browse files Browse the repository at this point in the history
  • Loading branch information
Isaac Connor committed Oct 30, 2023
1 parent f76046a commit cfec797
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion distros/ubuntu2004/control
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Source: zoneminder
Section: net
Priority: optional
Maintainer: Isaac Connor <[email protected]>
Build-Depends: debhelper (>= 11), sphinx-doc, python3-sphinx, dh-linktree, dh-apache2
Build-Depends: debhelper (>= 11), sphinx-doc, python3-sphinx, python3-sphinx-rtd-theme, dh-linktree, dh-apache2
,cmake
,libavcodec-dev
,libavdevice-dev
Expand Down

2 comments on commit cfec797

@efranzwa
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Isaac, I noticed that the read the docs builds were failing. According to Read the Docs website, they advise using .readthedocs.yaml to call a docs/requirements.txt which would list the dependencies, mainly the sphinx-rtd-theme==1.3.0. I was going to add these updates but it seems you are trying to add the dependencies in other ways. See this link which gives their instructions to fix this: https://docs.readthedocs.io/en/stable/guides/reproducible-builds.html. I can do this fix if you like but would need to revert all of the commits you did for RTD.

@connortechnology
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conf.py stuff definitely needs a revert. The distros/ubunt2004/control is correct I think. I'll setup the requirements.txt in amoment.

Please sign in to comment.