update build deps #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| git libc6-dev-armhf-cross libvncserver-dev qemu-user-static \ | ||
| tesseract-ocr libtesseract-dev wget && \ | ||
| git libc6-dev-armhf-cross libvncserver-dev python3-pip \ | ||
| qemu-user-static tesseract-ocr libtesseract-dev wget \ |
There was a problem hiding this comment.
You could remove tesseract I guess.
There was a problem hiding this comment.
We're not using that now, but it's needed for legacy OCR, isn't it? Being just a py dependency, it seems reasonable to keep it.
Thanks for the review!
There was a problem hiding this comment.
If you are using a Speculos version >= 0.2.8, Tesseract it not used at all on it.
You can obviously keep it, but it is unused and just increase the image size for no reason.
ftheirs
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE (yet), waiting for LedgerHQ/speculos#433 to be merged first.