-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return the ID of a created appointment from createAppointment #84
Conversation
src/schema/schema.graphql
Outdated
@@ -2010,6 +2010,11 @@ type SMimeMessage { | |||
content: String | |||
} | |||
|
|||
type createAppointmentResponse { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of creating new type just for two keys, we should use existing type available for appointments (CalendarItemHitInfo)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use existing graphql type
Updated, should be fine now |
@silentsakky sorry for the ping, but if there's no other issue with this PR, perhaps you can merge it as I don't have write access? |
@Faultless Sure I can merge but there is small review comment pending, would be good if you can handle that as well |
Sorry for the multiple pings, but its done @silentsakky |
can any of the code owners merge this if there's no further changes required? |
@Faultless I thought we only merge changes when feature is complete and everything is ready to be merged in develop, I am not seeing corresponding changes of zm-x-web repo, also it would be better to link your changes with ZX ticket to better track progress of the entire work |
My PR had a lot of interlap with Celina's work, and so we've rebased my work onto hers', and now the corresponding PR for these changes is here. |
That being said, this PR is minimal and has no breaking changes, so it should be safe to deploy. |
ok for now I am merging the changes, but you can follow below process to make sure netlify deploys work and you would be able to test changes before merging anything
|
Changes has been pushed with version 9.0.0-beta.2 |
Thank you @silentsakky ! |
Sorry guys, I had to revert this as this is breaking our stuff currently, this will fail zm-x-web as corresponding changes in query file is missing |
Created new PR #90 |
Companion PR of zm-x-web's #449.
This is needed because for Jitsi/OnlyOffice integrations, we require the
inviteId
generated upon creation of an appointment, in order to update that appointment on the spot.