PREAPPS-7390: Remove "/@zimbra" dependency from dev proxy #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
miteshsavani810
commented
Jul 24, 2023
•
miteshsavani810
commented
- Made default hostname as '' (blank)
- Added support to pass Agent in fetch request
- Added new serverUrl property to set zimbra server absolute url by desktop app such that cloud zimlet can use it for OAuth configuration.
silentsakky
reviewed
Jul 25, 2023
src/batch-client/index.ts
Outdated
| @@ -1,4 +1,5 @@ | |||
| import DataLoader from 'dataloader'; | |||
| import { Agent } from 'https'; | |||
There was a problem hiding this comment.
this is nodejs specific package, not sure we should use this in web code
miteshsavani810
requested review from
lavegupta,
damini-vashishtha,
HimanshuSojitraSynacor,
sitaram-mulik-synacor and
k-kato
as code owners
lavegupta
approved these changes
Aug 1, 2023
miteshsavani810
force-pushed
the
PREAPPS-7390
branch
2 times, most recently
from
06bad05 to
8b8533a
Compare
- Made default hostname as '' (blank) - Added support to pass Agent in fetch request - Added new serverUrl property to set zimbra server absolute url by desktop app such that cloud zimlet can use it for OAuth configuration.
miteshsavani810
force-pushed
the
PREAPPS-7390
branch
from
8b8533a to
66d14e9
Compare
damini-vashishtha
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.