Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SC2: Add location type tracking to client UI #67

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

Salzkorn
Copy link

@Salzkorn Salzkorn commented Oct 9, 2023

What is this fixing or adding?

This makes the client separate uncollected locations by location type, lists which location types are Trash/Nothing based on the corresponding YAML options, and colors mission names in a lighter blue if the remaining locations are all Trash/Nothing.

How was this tested?

Checking tooltips & colors with different amounts of remaining checks in Liberation Day.

If this makes graphical changes, please attach screenshots.

python_zCDsGRz7uw
python_2FpJn6m5IL

@Salzkorn Salzkorn requested a review from Ziktofel as a code owner October 9, 2023 06:56
@Ziktofel
Copy link
Owner

Ziktofel commented Oct 9, 2023

Note about these things:
The early unit location (if there's the early unit) is enabled, even if it's class is assigned to trash/nothing
Any locations subject to plando are enabled (this is done so the plando can actually happen)

See filter_locations() and get_plando_locations() in __init__.py

@Ziktofel Ziktofel merged commit f78472b into Ziktofel:sc2-next Oct 9, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants