Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mm/protoss upgrades #375

Merged
merged 3 commits into from
Dec 15, 2024
Merged

Conversation

MatthewMarinets
Copy link

@MatthewMarinets MatthewMarinets commented Dec 14, 2024

What is this fixing or adding?

Adding mothership war council upgrade and supplicant AA upgrade.
Pairs with data PR #339

Using this as an opportunity to take mothership off the OP items list and replace it with its SOA upgrade. The Mothership is still insane, but is now a resource/attention hog to blink it around, build pylons everywhere, escort it with energizers, and generally make sure it doesn't get stuck.

How was this tested?

The usual generate, start, /send routine.

If this makes graphical changes, please attach screenshots.

See data PR.

@MatthewMarinets
Copy link
Author

I got an email notification that a test failed. It also failed in #374 and should already be fixed there. (test_excluding_one_item_of_multi_parent_doesnt_filter_children )

@Ziktofel Ziktofel merged commit ec60686 into Ziktofel:sc2-next Dec 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants