sc2: Adding settings to control the mapping of race to colour in the launcher GUI #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthewMarinets
commented
Dec 3, 2024
worlds/sc2/gui_config.py
Outdated
| default_colours = { | ||
| 'TERRAN': (0.0838, 0.2898, 0.2346), | ||
| 'ZERG': (0.345, 0.22425, 0.12765), | ||
| 'PROTOSS': (0.18975, 0.2415, 0.345), |
There was a problem hiding this comment.
Working with settings is weird; attempting to pass in or import SC2Race caused the client startup to hang for some reason. So I just ended up working with strings, which I'm not fully happy about.
These defaults are the old colours multiplied by 0.345 (the colour component value of the grey button graphic).
|
|
…names changed by PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
New sc2 settings in host.yaml that allow controlling the colour of buttons in the GUI. I find the colours quite dark and murky and like some over-the-top colours myself. I admit the preset colours may be a little too bright, but I'm not sure how to get a good set of colours that allow for bright highlights while keeping the overall colours sane to look at. It may be that the best route is to allow additional configuration, like different colours for no-builds or fine control over borders.
How was this tested?
Changed the colours around a lot and restarted the client.
If this makes graphical changes, please attach screenshots.