Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item processing stability #333

Merged
merged 13 commits into from
Oct 27, 2024
Merged

Item processing stability #333

merged 13 commits into from
Oct 27, 2024

Conversation

Ziktofel
Copy link
Owner

@Ziktofel Ziktofel commented Oct 27, 2024

What is this fixing or adding?

See #309 and #310

Adds ItemFilterFlags to be processable by pool_filter
Start of splitting the removal of hero items and the related faction items as a preparation for cases where the player will want to play with Nova + Zerg, Kerrigan + Terran, etc
W/A upgrades aren't any longer locked by mission count (they are part of the logic instead)

How was this tested?

Generation and unit tests

If this makes graphical changes, please attach screenshots.

No

@Ziktofel Ziktofel marked this pull request as ready for review October 27, 2024 17:00
Copy link

@MatthewMarinets MatthewMarinets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of changes, I kind of skimmed over most of the rename stuff and that means I didn't go through the removed/excluded stuff in init.py with a fine-toothed comb. Aside from the user option pointing to the "locked" flag rather than "necessary", things look good.

Overall, this seems to cover most of #309 -- the hard part at least. The remainder is the "allow_generation_failures" option, which we can delay comfortably; and various naming/cleanup things like removing origin.

@Ziktofel Ziktofel merged commit 6f79e30 into sc2-next Oct 27, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants