-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Item processing stability #333
Conversation
… in order to beat the game
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of changes, I kind of skimmed over most of the rename stuff and that means I didn't go through the removed/excluded stuff in init.py with a fine-toothed comb. Aside from the user option pointing to the "locked" flag rather than "necessary", things look good.
Overall, this seems to cover most of #309 -- the hard part at least. The remainder is the "allow_generation_failures" option, which we can delay comfortably; and various naming/cleanup things like removing origin
.
What is this fixing or adding?
See #309 and #310
Adds ItemFilterFlags to be processable by
pool_filter
Start of splitting the removal of hero items and the related faction items as a preparation for cases where the player will want to play with Nova + Zerg, Kerrigan + Terran, etc
W/A upgrades aren't any longer locked by mission count (they are part of the logic instead)
How was this tested?
Generation and unit tests
If this makes graphical changes, please attach screenshots.
No