Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mm/war council destroyer #261

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

MatthewMarinets
Copy link

What is this fixing or adding?

  • Moved Reforged Bloodshard Core to be the Destroyer war council upgrade
  • Added Destroyer Resource Efficiency (not war council, claims category slot left by RBC)
  • War council upgrades are no longer given at map-init time, they come from generation time as starting inventory
  • Removed /option unit_nerfs
  • Added war council upgrades except RBC to API3 -> 4 compat items
  • Updated war council unit test to account for start inventory status

Pairs with data PR #223

How was this tested?

For RBC and RE, the usual: gen'd a new world, started a map /send to make sure the IDs lined up and the changes took correctly.

For starting inventory, updated the unit test.

If this makes graphical changes, please attach screenshots.

See data PR

@Ziktofel Ziktofel merged commit 9da013a into Ziktofel:sc2-next Jul 29, 2024
11 checks passed
@MatthewMarinets MatthewMarinets deleted the mm/war_council_destroyer branch December 10, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants