Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sc2: Adding an option to enable war council nerfs #224

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

MatthewMarinets
Copy link

@MatthewMarinets MatthewMarinets commented Jul 1, 2024

What is this fixing or adding?

Adding an option to enable war council nerfs, to hopefully facilitate testing out war council nerf items as they're implemented.
Pairs with Data PR #157
Progress on issue #152

Migration plan

  • This setup should work fine for development, but I wouldn't want to ship this unless all the war council nerfs are done. I think core recently added a visibility setting to options, we could use that to hide it if it comes to that?
  • We should consider if we want this toggle to be an option in the final release, or if we should just get people to put "War Council" in their start inventory. I could go either way.

How was this tested?

  • Set allow_unit_nerfs to true in a yaml, generated, and verified the option was pulled in with /option unit_nerfs
  • Generated with the option set to true, checked the spoiler, verified Zealot whirlwind was in the item pool
  • Set the option to true, started a mission, verified Zealots, Stalkers, Sentinels, and Centurions were all in their nerfed/non-war council state
  • Set the option to false, started a mission, verified Stalkers had phase reactor and Zealots had whirlwind

If this makes graphical changes, please attach screenshots.

None

@MatthewMarinets MatthewMarinets marked this pull request as ready for review July 3, 2024 03:16
@MatthewMarinets MatthewMarinets requested a review from Ziktofel as a code owner July 3, 2024 03:16
@Ziktofel Ziktofel merged commit e4ac3d4 into Ziktofel:sc2-next Jul 3, 2024
11 checks passed
@MatthewMarinets MatthewMarinets deleted the mm/unit_nerfs_option branch July 8, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants