sc2: Adding larva command card submenu for advanced strains #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthewMarinets
force-pushed
the
mm/larva_submenus
branch
from
419ce69 to
11b6df0
Compare
|
Added the gamestrings for the submenu buttons. Note the submenu buttons are available immediately, even if no advanced morphs are unlocked. |
|
Added a flag so the advanced morphs subtab only shows up if you have a unit in there. Unfortunately, it greys the submenu out if you don't have the requirements for any unit in the subtab :/ |
|
Fixed the greyed-out submenu button issue. It involved manually adding all advanced morphs to a requirement, which is unfortunate as it's an easy thing to forget if adding new advanced morphs in future. I think it's easy enough to spot and fix if we do add more, though |
…ng pygalisk armour by 1
Ziktofel
reviewed
Dec 5, 2024
| @@ -196,6 +196,8 @@ Button/Hotkey/AP_K5Leviathan=V | |||
| Button/Hotkey/AP_KerriganUltimateAbilites=U | |||
| Button/Hotkey/AP_KhaydarinMonolith=D | |||
| Button/Hotkey/AP_Lair=L | |||
| Button/Hotkey/AP_LarvaAdvancedMorphs=X | |||
| Button/Hotkey/AP_LarvaBasicMorphs=B | |||
There was a problem hiding this comment.
Escape should be the default hotkey for exiting a submenu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also moving pygalisks to larva
Made description and logic changes to pygalisk in client PR #364
Tentative new layout:
(scourge hotkey changed locally S -> X, the rest should all be default)
The submenu is sticky, so multiple advanced morphs can be built after opening the submenu once.
I hope this opens the door to more basic morphs, and possibly some "morph the advanced unit straight from larva" upgrades, particularly for banelings (AI gets them sometimes, would get me to build them more) and Vipers (melee-style).
TODO