Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sc2: Adding carrier wc upgrade -- repair drones #278

Merged
merged 9 commits into from
Sep 14, 2024

Conversation

MatthewMarinets
Copy link
Contributor

@MatthewMarinets MatthewMarinets commented Sep 14, 2024

Adding Carrier war council upgrade -- repair drones.

Progress on #152
Pairs with client PR #302

Known issues

  • Carriers without the upgrade can still build the repair drones, and only deploy them if they deploy all their interceptors. Investigating Fixed by specifying the magazine abil on the use magazine effect
  • Getting the upgrade while a carrier is building interceptors doesn't give healing drones until after interceptors are done building. I think this is how the Karax upgrade behaves, so I'd prefer to leave it.
    • If this is really desirable to change, I think it's better to look at how war3 mod does it for exhume corpses. Uses a CEffectCreateUnit and a CEffectLoadContainer. I think this is preferable to doing it with triggers

Without upgrade

image
image
image
image
image
image

With upgrade

image
image

image
image
image
image

@Ziktofel Ziktofel merged commit 3923300 into Ziktofel:sc2-next Sep 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants