Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purifier carrier rework #276

Merged
merged 15 commits into from
Sep 10, 2024

Conversation

MatthewMarinets
Copy link
Contributor

@MatthewMarinets MatthewMarinets commented Sep 5, 2024

Essentially redid / adapted the changes from PR #173.

  • Renamed the unit to the Trireme
  • Replaced the purifier interceptors with Bombers, which are larger and drop bombs which do big splash damage but only hit ground

Pairs with client PR #299

In some quick testing, I found the damage output vs ground was absolutely ridiculous, but it wiped out friendly units very readily, which I think is a fun balance. If we remove friendly-fire, I'd want to also reduce the damage output.

image
(Corrected this saying they could hit air after taking the picture):
image
image

@MatthewMarinets
Copy link
Contributor Author

Took notes on what was added/removed:
trireme.md

@Ziktofel
Copy link
Owner

Ziktofel commented Sep 5, 2024

Damage would be subject to playtesting

@Ziktofel
Copy link
Owner

Ziktofel commented Sep 5, 2024

Snímek obrazovky pořízený 2024-09-05 23-21-50
If I attack an air target, the bomber interceptors move out, and stop near Trireme

@Ziktofel
Copy link
Owner

Ziktofel commented Sep 5, 2024

The thing is that before the unit had just real weapon that handled both interceptors and beam with both Ground and Air targeting, while the beam started to work only if the attack target is air. IIRC it's done this way (and not like multi-lock) due to effect being channeled, thus making the unit busy

@Ziktofel
Copy link
Owner

Ziktofel commented Sep 5, 2024

Use Assets\Textures\btn-unit-collection-purifier-bomber.dds asset to display bombers (dummy Trireme weapon, train icon)

@MatthewMarinets
Copy link
Contributor Author

Fixed the icons, good catch.
image

Interceptors also no longer come out vs air.

@MatthewMarinets
Copy link
Contributor Author

Missed the ability in that last one. Now fixed
image

@MatthewMarinets
Copy link
Contributor Author

Did a few tests to make sure things weren't broken, and found that they were crazy popular. Three triremes could take down a base, would 4-volley a nexus, etc. I tuned the numbers down a bit, so a volley of bombs is 3 bombs instead of 4, and reduced the base damage from 12 -> 9. Tried again, they're still just as flashy, and probably still too strong.

@Ziktofel Ziktofel merged commit 54bcc96 into Ziktofel:sc2-next Sep 10, 2024
1 check passed
@Ziktofel Ziktofel mentioned this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants