Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing NCO Despawns #234

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Fixing NCO Despawns #234

merged 1 commit into from
Aug 2, 2024

Conversation

Gemster312
Copy link

What Was Fixed

Changed bonus objective despawning from an arbitrary "At 3 seconds game-time" to "When the Archipelago is done loading".

Background

During the "Objective Categorization" updates, I also introduced a feature into many maps that despawned already-collected bonus objectives or deactivated associated voicelines on repeat playthroughs. However, they despawned at an arbitrary time of "3" seconds game-time. For players with slower CPUs, this caused an issue as the Archipelago might not be done loading by that 3-second mark and thus despawn objectives incorrectly. This change ensures that any/all of the despawns only occur after the Archipelago is fully done loading.

Maps Updated

  • Dark Skies
  • Flashpoint
  • In the Enemy's Shadow
  • Night Terrors
  • Sudden Strike
  • Trouble in Paradise

Testing

Opened a few maps, collected the bonus objectives, quit, and restarted the map. Ensured the objects despawned correctly.

@Ziktofel Ziktofel merged commit 8b36d2c into Ziktofel:sc2-next Aug 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants