Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sc2: replaced skylord interceptors with a laser #174

Merged
merged 4 commits into from
Jul 16, 2024

Conversation

MatthewMarinets
Copy link
Contributor

@MatthewMarinets MatthewMarinets commented Jul 8, 2024

Reworking skylord to be different from a reskinned carrier. Gave it a slow but high-damage laser that deals damage in a line.

WIP

  • Apply attack upgrades
  • Test Squad Sight
  • Change teleport around -- maybe shorter cooldown / activation, but shorter range? Going to leave this for another day for time/availability reasons
  • Fix a bug where one attack can hit the same unit multiple times over

@MatthewMarinets MatthewMarinets marked this pull request as ready for review July 14, 2024 05:21
@MatthewMarinets MatthewMarinets marked this pull request as draft July 14, 2024 05:21
…ned ground-effect actor scaling, removed red tint, fixed double-dealing damage bug, applied air upgrades
@MatthewMarinets
Copy link
Contributor Author

image
skylord_test
image
image
image

+tested that buffing range with havoc leads to increased range and still does damage at the end of the range.

@MatthewMarinets MatthewMarinets marked this pull request as ready for review July 14, 2024 06:13
Copy link
Owner

@Ziktofel Ziktofel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: You can't attack own units if under Havoc's range buff (you can without that)

@MatthewMarinets
Copy link
Contributor Author

Bug: You can't attack own units if under Havoc's range buff (you can without that)

I can't seem to find a place to fix this. Would you happen to know what causes this behaviour? My best guess is that specifically for squadsight the aoe damage triggers first, which markers the friendly unit but doesn't deal damage because of the filters, then the single-target damage doesn't trigger because of the marker. Not sure if that's the case or how to get around that, though?

@Ziktofel Ziktofel merged commit 9e37046 into Ziktofel:sc2-next Jul 16, 2024
1 check passed
@MatthewMarinets MatthewMarinets deleted the mm/skylord_rework branch July 24, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants